Comment 51 for bug 319825
Revision history for this message
| Carlos Corbacho (carlos.corbacho) wrote | #51 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
@Andy
I had been meaning to do something like this patch for a while, though I wasn't aware that the Aspire One's broken/ lack of WMI support broke things so badly for NetworkManager. A few things though:
1. You may want to update the patch details though - the bug here is that the Aspire One's ACPI-WMI interface just provides empty, useless methods that do nothing - calling into them doesn't return any result, but there's no way yet to distinguish it from a working Acer ACPI-WMI interface without blacklisting, since it advertises all the GUIDs that acer-wmi can drive.
2. Consider changing the DMI matching string - DMI can match on partial strings, so matching on 'AOA1' should be enough to catch all the Aspire One models with one DMI entry (in case there are more than just the 110 and 150 out there).
Other than that, if this patch is ready to go (and it looks good to me so far), I can add my sign-off to it and we can get it merged upstream.