Comment 25 for bug 1998643

Revision history for this message
Michael Reed (mreed8855) wrote :

Hi Don,

I re-added this patch "(64fc9015fbeb scsi: smartpqi: Switch to attribute groups)" as it fixed the issues with cherry picking. The need to verify that I need to add this and remove the .attr suffix? This currently builds and it is in the 5.19 kernel as is. I just need to verify that I need to remove the .attr suffix?

static struct attribute *pqi_sdev_attrs[] = {
        &dev_attr_lunid.attr,
        &dev_attr_unique_id.attr,
        &dev_attr_path_info.attr,
        &dev_attr_sas_address.attr,
        &dev_attr_ssd_smart_path_enabled.attr,
        &dev_attr_raid_level.attr,
        &dev_attr_raid_bypass_cnt.attr,
        &dev_attr_sas_ncq_prio_enable.attr,
        NULL
};

Second, this following line breaks the build.

+ .shost_groups = pqi_shost_groups,

I need to know if it is needed? or is there another patch that fixes it or can I just remove it?
When I removed it, the build succeeded.