Comment 4 for bug 1060372

Revision history for this message
Stefan Freyr (stefan-freyr) wrote :

Hi. Just checking up on this... it's my understanding that this is just a matter of adding the model name to a source file really and from what I can see this hasn't been done:
http://git.kernel.org/?p=linux/kernel/git/tiwai/sound.git;a=blob;f=sound/pci/hda/patch_realtek.c;h=bb93f927f7be97ac7280c87fe2cccbf448c73809;hb=4407be6ba217514b1bc01488f8b56467d309e416

There is a line for T430s there but none for T430.

But this brings me to a (potentially very stupid) question. Why in the world are these "quirktables" kept in a source file that needs rebuilding for each new model that comes along? Wouldn't it be a better idea to keep these in a config file that people can edit? This should simplify testing, instead of having to rebuild a kernel, you can just edit a config file and report if that worked. Am I missing something here?