The output is:
dytc_profile_refresh: mmc=0 psc=1 mmc_get=0 funcmode=0 output=0x1f001 perfmode=15
So using psc mode, it retrieves DYTC (0x1f001) as follows:
0x1.... -> VSTD=1 -> STD mode
0x.f... -> CICM=0xf, DYTC_GET_MODE_BIT(12) -> dunno what it is in STD
0x..0.. -> CICF=0x0, DYTC_GET_FUNCTION_BIT(8) -> DYTC_FUNCTION_STD
0x....1 -> GOOD
But convert_dytc_to_profile() doesn't handle this at all. Do I have a newer DYTC interface? Or a broken one? Case (0x00)
{ Local1 = 0x0100 Local1 |= 0x80000000 Local1 |= 0x00 Local1 |= 0x01
}
Downstream report: /bugzilla. suse.com/ show_bug. cgi?id= 1215602
https:/
LKML link:
https://<email address hidden>/
according to logs, since 6.3 (up to 6.5.4 now), I repeatedly see: acpi/platform_ profile. c:74 profile_ show+0xb1/ 0x100 [platform_profile] 644bb80e3c1534d 801bf4cb36 21CRS0K83K, BIOS R22ET60W (1.30 ) 02/09/2023 profile_ show+0xb1/ 0x100 [platform_profile] b97db0 EFLAGS: 00010296 0(0000) GS:ffff895b9f10 0000(0000) knlGS:000000000 0000000 seq_show+ 0xab/0x100 iter+0x123/ 0x480 0x1b8/0x300
> WARNING: CPU: 14 PID: 962 at drivers/
> platform_
> Modules linked in: ccm michael_mic ...
> CPU: 14 PID: 962 Comm: power-profiles- Kdump: loaded Not tainted
> 6.5.4-6-default #1 openSUSE Tumbleweed (unreleased)
> dd37106c593be78
> Hardware name: LENOVO 21CRS0K83K/
> RIP: 0010:platform_
> Code: d0 a8 ...
> RSP: 0018:ffff9c1ac0
> RAX: 0000000000000000 RBX: 0000000000000000 RCX: 000000008fc35be0
> RDX: 0000000000000000 RSI: ffff9c1ac0b97db4 RDI: ffffffffc0a8b0a0
> RBP: ffff8955ca540000 R08: ffff895b9f1ed180 R09: ffff895559ea1bc0
> R10: 00000000031a400e R11: 000000000003f680 R12: ffff895b9f1ed180
> R13: ffff9c1ac0b97e50 R14: 0000000000000001 R15: ffff9c1ac0b97ee8
> FS: 00007f71b0e7190
> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 00007fe402ea3400 CR3: 000000012004c000 CR4: 0000000000750ee0
> PKRU: 55555554
> Call Trace:
> <TASK>
> sysfs_kf_
> seq_read_
> vfs_read+
It's: profile_ names)) ))
WARN_ON((profile < 0) || (profile >= ARRAY_SIZE(
So I put there one more print: >profile_ get);
dev_warn(dev, "profile=%d profile_get=%ps\n",
profile, cur_profile-
and I see: get=dytc_ profile_ get [thinkpad_acpi] get=dytc_ profile_ get [thinkpad_acpi] get=dytc_ profile_ get [thinkpad_acpi] get=dytc_ profile_ get [thinkpad_acpi] get=dytc_ profile_ get [thinkpad_acpi] get=dytc_ profile_ get [thinkpad_acpi] get=dytc_ profile_ get [thinkpad_acpi]
: profile=-1883022368 profile_
: profile=-1510173440 profile_
: profile=-1510173440 profile_
: profile=-966231712 profile_
: profile=-1578420592 profile_
: profile=-1578420592 profile_
: profile=-1578420592 profile_
I wonder about dev passed to dytc_profile_get() having empty name (nothing before colon above)? Is that expected?
Ah, convert_ dytc_to_ profile( )'s retval is not checked in dytc_profile_ refresh( ). Adding: platform/ x86/thinkpad_ acpi.c platform/ x86/thinkpad_ acpi.c refresh( void)
return;
--- a/drivers/
+++ b/drivers/
@@ -10418,7 +10418,14 @@ static void dytc_profile_
perfmode = (output >> DYTC_GET_MODE_BIT) & 0xF; dytc_to_ profile( funcmode, perfmode, &profile); dytc_to_ profile( funcmode, perfmode, &profile); capabilities & BIT(DYTC_FC_MMC)), capabilities & BIT(DYTC_FC_PSC)), get_available, funcmode, output, perfmode); profile) {
dytc_ current_ profile = profile;
platform_ profile_ notify( );
- convert_
+ err = convert_
+ if (err) {
+ pr_warn("%s: mmc=%u psc=%u mmc_get=%u funcmode=%d output=0x%x perfmode=%d\n",
+ __func__, !!(dytc_
+ !!(dytc_
+ dytc_mmc_
+ return;
+ }
if (profile != dytc_current_
fixes the warning, of course.
The output is: refresh: mmc=0 psc=1 mmc_get=0 funcmode=0 output=0x1f001 perfmode=15
dytc_profile_
So using psc mode, it retrieves DYTC (0x1f001) as follows: MODE_BIT( 12) -> dunno what it is in STD FUNCTION_ BIT(8) -> DYTC_FUNCTION_STD
0x1.... -> VSTD=1 -> STD mode
0x.f... -> CICM=0xf, DYTC_GET_
0x..0.. -> CICF=0x0, DYTC_GET_
0x....1 -> GOOD
But convert_ dytc_to_ profile( ) doesn't handle this at all. Do I have a newer DYTC interface? Or a broken one?
Case (0x00)
Local1 = 0x0100
Local1 |= 0x80000000
Local1 |= 0x00
Local1 |= 0x01
{
}
I.e. version 8.0, it seems.
My DYTC for CMD_GET looks like:
Case (0x02)
{
Local5 = VSTD /* \VSTD */
Local5 |= (VCQL << 0x01)
Local5 |= (VSTP << 0x04)
Local5 |= (VADM << 0x07)
Local5 |= (VTMS << 0x09)
Local5 |= (VDLS << 0x0A)
Local5 |= (VMSC << 0x0C)
Local5 |= (VPSC << 0x0D)
Local1 = (CICF << 0x08)
If ((CICF == 0x03))
{
CICM = SMYH /* \SMYH */
}
ElseIf ((CICF == 0x0B))
{
CICM = SMMC /* \SMMC */
}
ElseIf ((CICF == 0x0D))
{
CICM = SPSC /* \SPSC */
}
ElseIf ((CICF == 0x0F))
{
CICM = SAMT /* \SAMT */
}
ElseIf ((CICF == 0x07))
{
CICM = SADM /* \SADM */
}
Else
{
CICM = 0x0F
}
Local1 |= (CICM << 0x0C)
Local1 |= (Local5 << 0x10)
Local1 |= 0x01
}