Comment 34 for bug 307306

Revision history for this message
Peter Clifton (pcjc2) wrote :

Blocking out XRRGetScreenSizeRange does indeed also fix the problem, however I noted that the call fills in information which may be accessed via various APIs, so I'd prefer to leave it in there if possible.

At least, disabling the update when recieving an output property notification just means that the performance problem is taken care without harming the update of information feeding those getters.

If we were being really fancy, we could actually inspect the notification for change of output property, and just ignore the brightness change ones. (If you're concerned that TV-out details might be relevant to re-query Xrandr).

Looking at this though, I don't think think the applications concerend actually care about output properties. GDK's "monitors-changed" emission, might arguably be interesting in the absence of a "output-property-changed" signal.

In the longer term, I think if GDK is going to attempt to wrap Xrandr, it needs to do a better mapping of these notifications, and / or proxying of information gleaned from the change notification events.