Comment 11 for bug 224559

Revision history for this message
Dmitriy Geels (dmig) wrote :

Here is modified version of patch from http://ubuntuforums.org/showthread.php?t=838210
The one posted there has one flaw: it will rotate image for all devices, it work with.

Usecase:
User has laptop with webcam mounted upside-down. He applies patch from forum, he is happy -- webcam image is ok. Then he connects external UVC webcam -- image from it is upside down, because driver just do rotation.

My modification adds quirk for webcam models, known to be mounted upside-down. Driver will not rotate image for others.

Also my patch is made against latest UVC source, so applying it to uvc from ubuntu kernel will reject one hunk (patch will fail to find surrounding lines). Don't be afraid of this, just manually edit uvcvideo.h and following add line there:
#define UVC_QUIRK_ROTATE_IMAGE 0x00000100

My patch won't be accepted to uvc, because: "Linus said, that all image processing must be done in userspace". Even if this is a fix of hardware flaw.
But may be it will be included in Ubuntu?

Also, I consider that existing uvcvideo source should be updated. It is 1-2 years old already and has at least one problem, which was already fixed in upstream: webcam wont work after resume from hibernate.