Comment 12 for bug 40177

Revision history for this message
In , Johan Dahlin (jdahlin-deactivatedaccount) wrote :

(From update of attachment 3116)
Looks good, some nitpicks.

>Index: kiwi/environ.py

> import locale
> import os
> import sys
>+from os.path import dirname, abspath

This is not allowed, just use the name directly, since they're
no need to explicitly importing os.path.

>+ # Add "current" (as in the directory of the main script being
>+ # run) to resource paths to look at when searching for "glade"
>+ # resources (see http://bugzilla.async.com.br/show_bug.cgi?id=2409)
>+ #
>+ # Note this path is absolute, while in general we deal with
>+ # relative paths here. However the join() function is smart
>+ # enough to ignore the prefix if it see's an absolute path as
>+ # the second argument.
>+ self.add_resource("glade", dirname(abspath(sys.argv[0])))
>+
>+ # Add some compressed formats as alternative extensions to
>+ # "glade" resources. A patch has been added to gazpacho trunk
>+ # (rev. 2251) to support loading those compressed formats.
>+ self.add_alternative_extensions("glade", ".bz2", ".gz")

Can this be determined in runtime somehow?
So the extensions are only added if gazpacho actually supports them.