Comment 41 for bug 410466

Revision history for this message
In , Daniel Brownlees (dbrownlees) wrote :

Created attachment 36296
Close event when NoSound is set

Here is a patch that fixes this issue, as I discussed above. It closes the event if NoSound is set, rather than leaving it open. I have tested on the 4.3 branch and it fixes this issue.

Can someone please apply this for 4.3.1? It should be applied to trunk as well.

Further background: The issue is exposed by R997746 (trunk) which has been backported to the Kubuntu packages. The revision removes the 6 second timeout on events preventing them closing automatically, so hence the sound event stays open indefinitely. Any other sound events will also never close The above fix also has the upside that it speeds login and logout up by those six seconds if NoSound is set in vanilla 4.3 without R997746 :-).