Comment 37 for bug 410466

Revision history for this message
In , Daniel Brownlees (dbrownlees) wrote :

Hi Leo
>
> Are you sure about this? I am looking at the function (maybe it was recently
> fixed). It doesn't seem to be attempting to _play_ it if the Private object is
> set to NoSound.

No, I am definately not sure :). I agree with your reading.

> However, we are not calling finish( eventId ) , which seems mandatory
> for other processes calling us to know _we_ are done [2]. So, the clean way to
> do this is to include it in the same if, just add one more condition
> (basically, the code you suggested above, but in line 254, in an else if()
> condition.

Still, why load the sound file if it won't be played? I would think
the cleanest solution is to check at the beginning of the function and
close the event appropriately.

BTW. Has anyone been able to test this and see if it resolves the logout bug?