Comment 34 for bug 410466

Revision history for this message
In , Daniel Brownlees (dbrownlees) wrote :

Leo Milano wrote:
> As an alternative to checking for a null player (or NoSound), wouldn't it be
> possible to make these notification asynchronous, such that no other process
> waits for them and login/logout can complete even if they fail, or take longer
> than normal?)

I think that is a separate issue, though a good suggestion to make the logout procedure more robust.

There is still the bug in KNotify where it will load and then attempt to play a sound file even when it never initialised a player because NoSound is set. The bug actually gets tripped by all sorts of things - login sounds, alerts, or any other sound event, but because it doesn't block anything else, and the expected behaviour is correct (as in, no sound is produced) I don't think it has ever been noticed.