Comment 37 for bug 214914
Revision history for this message
| Scott Kitterman (kitterman) wrote Re: [Bug 214914] Re: jockey-gtk crashed with AttributeError in enabled() | #37 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
On Sun, 13 Apr 2008 10:47:09 -0000 Martin Pitt <email address hidden>
wrote:
...
>Scott: I don't doubt that it was important to fix. But it did not have
>any bug # in the changelog, so I could not even (quickly) find where to
>look. Passing an additional flag to the caller can happen without
>breaking the API, e. g. as a new attribute of the result object, or a
>new function, etc.
Agreed and I wasn't being critical of you reverting the patch. That was
obviously the right thing to do given the magnitude of the problem.
If the new argument were given a correct default so the function would work
with one or two arguments then the api problem could be avoided. This
change was the last step to getting displayconfig working on no xorg.con
systems. It would be of significant benifit to Kubuntu is we could get a
corrected version uploaded. Unfortunately, I offline until Wednesday and
can't tend to it personally.