Ubuntu
kball package

  1. Bug #611867
  2. Comment #4

Comment 4 for bug 611867

Revision history for this message
Bhavani Shankar (bhavi) wrote :

Hello mohar!

here is a review of your patch!

1. why are you reverting the debian patch level change in the patch?

2. There is no mention of maintainer with @ubuntu.com mail address (Hint: use update-maintainer from the ubuntu dev tools package to set Maintainer field)

3. AFAIK there is no need of including <sys/types.h> as <sys/stat.h> includes definition for mkdir function so the patch will reduce further

keeping the above points in mind I have reworked and I have pasted my own patch for your reference

regards