Comment 38 for bug 206921

Revision history for this message
In , Danny Kukawka (danny-kukawka) wrote :

Okay, thanks for the info. The fix was also verified by the SUSE user. I've commited it to git master:

commit 9f5219eaa6c7423870b031fdfa07de6a84f25d6e
Author: Danny Kukawka <email address hidden>
Date: Fri Apr 25 22:18:24 2008 +0200

    fix macbook-backlight for ix86

    Fixed macbook-backlight for ix86 with a patch contributed by user
    'godlygeek' via: https://bugs.launchpad.net/hal/+bug/206921

    from comment #27:
    > This patch should fix it. Problem is that we're doing bitwise
    > arithmetic on a signed long that happens to be negative.
    > Wackiness ensues, making the result an invalid offset for mmap().
    > Changing the long to unsigned fixes it.