Comment 91 for bug 207072

Revision history for this message
Steve Langasek (vorlon) wrote :

So the (a?) key difference between smbbrowse and smb seems to be that smbbrowse declares its sub-entries as "mountable". Other unavailable bookmarks don't cause stalls, and neither does smbbrowse if I comment out the mountable support. On the other hand, if I comment out the mountable support, the shares are no longer browseable, so that's not much of a solution!

I think that the correct fix here may be to not actually perform the full login check at the "mount" stage and returning a simple success, deferring the password handling until the cache update stage. Since an smbbrowse record is flat, the two should be nearly equivalent in the general case, possibly differing only here in the panel's bookmark handling.

However, I'm not sure I have time to implement such a revised patch in time for the 8.04.1 point release. I fear we may have to roll back the gvfs fixes in the short term and try again after .1 is out.