Comment 90 for bug 491521

Revision history for this message
Andrea Cimitan (cimi) wrote : Re: [Bug 491521] Re: Decorations and RGBA

Haven't tried yet... but I will merge the patch to git ASAP :) thanks
Is the cairo_clip necessary if you replace cairo_paint with cairo_fill?

2010/1/11 Michael Coupet <email address hidden>:
> Cimitan, I think the problem with webkit is actually in murrine. The
> problem goes away if in murrine_style.c lines 269-279 you change:
>
> if (DETAIL ("entry_bg"))
> {
>        /* Draw (erase) the background */
>        cairo_set_operator (cr, CAIRO_OPERATOR_CLEAR);
>        cairo_paint (cr);
>        cairo_set_operator (cr, CAIRO_OPERATOR_OVER);
>
>        murrine_set_color_rgba (cr, &colors->base[state_type], ENTRY_OPACITY);
>        cairo_rectangle (cr, 0, 0, width, height);
>        cairo_fill (cr);
> }
>
> to
>
> if (DETAIL ("entry_bg"))
> {
>        /* Draw (erase) the background */
>        cairo_set_operator (cr, CAIRO_OPERATOR_CLEAR);
>        cairo_rectangle (cr, x, y, width, height);
>        cairo_clip(cr);
>        cairo_paint (cr);
>        cairo_set_operator (cr, CAIRO_OPERATOR_OVER);
>
>        murrine_set_color_rgba (cr, &colors->base[state_type], ENTRY_OPACITY);
>        cairo_rectangle (cr, x, y, width, height);
>        cairo_fill (cr);
> }
>
> Thanks for redirecting me btw.
>
> --
> Decorations and RGBA
> https://bugs.launchpad.net/bugs/491521
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in Ayatana Ubuntu Love Project: In Progress
> Status in GNOME Desktop Common Files: Unknown
> Status in GTK+ GUI Toolkit: Unknown
> Status in Nautilus: Unknown
> Status in “gnome-desktop” package in Ubuntu: Fix Released
> Status in “gnome-screensaver” package in Ubuntu: New
> Status in “gtk+2.0” package in Ubuntu: In Progress
> Status in “gtk-recordmydesktop” package in Ubuntu: Invalid
> Status in “libgksu” package in Ubuntu: Fix Released
> Status in “nautilus” package in Ubuntu: Fix Released
>
> Bug description:
> For Lucid, I'd like to get the new decorations feature integrated.  This patch adds support for doing client-side window decorations, which pulls in support for RGBA colormaps.
>
> The new decorations feature requires explicit support from a theme before it becomes active (it defaults to being disabled).  However, RGBA support is enabled by default and there is a chance for some fallout from this being added.
>
> To unsubscribe from this bug, go to:
> https://bugs.launchpad.net/ayatana-ubuntu/+bug/491521/+subscribe
>

--
Andrea Cimitan - http://www.cimitan.com