function Fix_grub_config() {
if grep -q "^GRUB_HIDDEN_TIMEOUT=0$" /etc/default/grub || grep -q "^GRUB_HIDDEN_TIMEOUT_QUIET=true$" /etc/default/grub; then
echo -en "ACTION:\tFixing Grub config... "
sed -i "s/^GRUB_HIDDEN_TIMEOUT=0$/#GRUB_HIDDEN_TIMEOUT=0/" /etc/default/grub
sed -i "s/^GRUB_HIDDEN_TIMEOUT_QUIET=true$/#GRUB_HIDDEN_TIMEOUT_QUIET=true/" /etc/default/grub
echo "Done."
fi
}
But this fix brings up a new issue for me personally. When running the dist-upgrade, it now shows a pop-up from "grub-pc config", complaining that I modified /etc/default/grub asking me what to do.
As I'm trying to run the dist-upgrade non-interactively, this is a bigger issue for me than the warning, so I will not perform this fix...
2)
rmdir: failed to remove `/var/lib/os-prober/mount': Device or resource busy
By using set -xv I was able to track down this issue a bit further:
if [ "$mounted" ]; then
for test in /usr/lib/os-probes/mounted/*; do debug "running subtest $test" if [ -f "$test" ] && [ -x "$test" ]; then if "$test" "$partition" "$tmpmnt" "$type"; then debug "os found by subtest $test" if ! umount "$tmpmnt"; then warn "failed to umount $tmpmnt" fi case "$type" in btrfs) # umount to account for the bind-mount if [ -x "$tmpmnt/@/lib" ] && \ ! umount $tmpmnt; then warn "failed to umount $tmpmnt" fi ;; esac rmdir "$tmpmnt" || true exit 0 fi fi done
if ! umount "$tmpmnt"; then warn "failed to umount $tmpmnt"
fi
fi
+ [ ]
rmdir "$tmpmnt" || true
+ rmdir /var/lib/os-prober/mount
rmdir: failed to remove `/var/lib/os-prober/mount': Device or resource busy
PERSONAL CONCLUSION (please correct me if I'm wrong):
Although it is not nice, I don't see anything dangerous in not being able to successfully unmount a FS and clean up that folder.
After a reboot (which I do anyway), most of this should be solved anyway...
3)
grub-probe: error: unknown filesystem.
By using set -xv I was able to track down this issue a bit further:
root@dcmilphlum173:~# ls -la /dev/mapper/vgos-rootsnapvol
lrwxrwxrwx 1 root root 7 Mar 18 06:30 /dev/mapper/vgos-rootsnapvol -> ../dm-6
root@dcmilphlum173:~# ls -la /dev/vgos/rootsnapvol
lrwxrwxrwx 1 root root 7 Mar 18 06:30 /dev/vgos/rootsnapvol -> ../dm-6
root@dcmilphlum173:~#
PERSONAL CONCLUSION (please correct me if I'm wrong):
Also here I don't see any big danger, as grub shouldn't do anything with those snapshot volumes anyway...
1)
Warning: Setting GRUB_TIMEOUT to a non-zero value when GRUB_HIDDEN_TIMEOUT is set is no longer supported.
This warning is because of https:/ /bugs.launchpad .net/ubuntu/ +source/ grub2/+ bug/1258597
I was able to solve it by:
function Fix_grub_config() { HIDDEN_ TIMEOUT= 0$" /etc/default/grub || grep -q "^GRUB_ HIDDEN_ TIMEOUT_ QUIET=true$ " /etc/default/grub; then HIDDEN_ TIMEOUT= 0$/#GRUB_ HIDDEN_ TIMEOUT= 0/" /etc/default/grub HIDDEN_ TIMEOUT_ QUIET=true$ /#GRUB_ HIDDEN_ TIMEOUT_ QUIET=true/ " /etc/default/grub
if grep -q "^GRUB_
echo -en "ACTION:\tFixing Grub config... "
sed -i "s/^GRUB_
sed -i "s/^GRUB_
echo "Done."
fi
}
But this fix brings up a new issue for me personally. When running the dist-upgrade, it now shows a pop-up from "grub-pc config", complaining that I modified /etc/default/grub asking me what to do.
As I'm trying to run the dist-upgrade non-interactively, this is a bigger issue for me than the warning, so I will not perform this fix...
2) os-prober/ mount': Device or resource busy
rmdir: failed to remove `/var/lib/
By using set -xv I was able to track down this issue a bit further:
/usr/sbin/ grub-mkconfig -o /boot/grub/grub.cfg d/30_os- prober "`os-prober | tr ' ' '^' | paste -s -d ' '`" os-probes/ 50mounted- tests /dev/sda5
--> /etc/grub.
--> OSPROBED=
--> /usr/bin/os-prober
--> /usr/lib/
if [ "$mounted" ]; then os-probes/ mounted/ *; do
debug "running subtest $test"
if [ -f "$test" ] && [ -x "$test" ]; then
if "$test" "$partition" "$tmpmnt" "$type"; then
debug "os found by subtest $test"
if ! umount "$tmpmnt"; then
warn "failed to umount $tmpmnt"
fi
case "$type" in
btrfs)
# umount to account for the bind-mount
if [ -x "$tmpmnt/@/lib" ] && \
! umount $tmpmnt; then
warn "failed to umount $tmpmnt"
fi
;;
esac
rmdir "$tmpmnt" || true
exit 0
fi
fi
done
warn "failed to umount $tmpmnt"
for test in /usr/lib/
if ! umount "$tmpmnt"; then
fi
fi
+ [ ]
rmdir "$tmpmnt" || true os-prober/ mount os-prober/ mount': Device or resource busy
+ rmdir /var/lib/
rmdir: failed to remove `/var/lib/
PERSONAL CONCLUSION (please correct me if I'm wrong):
Although it is not nice, I don't see anything dangerous in not being able to successfully unmount a FS and clean up that folder.
After a reboot (which I do anyway), most of this should be solved anyway...
3)
grub-probe: error: unknown filesystem.
By using set -xv I was able to track down this issue a bit further:
/usr/sbin/ grub-mkconfig -o /boot/grub/grub.cfg d/30_os- prober "`os-prober | tr ' ' '^' | paste -s -d ' '`" os-probes/ 50mounted- tests /dev/mapper/ vgos-rootsnapvo l vgos-rootsnapvo l -t fs
--> /etc/grub.
--> OSPROBED=
--> /usr/bin/os-prober
--> /usr/lib/
--> grub-probe -d /dev/mapper/
I'm able to reproduce the error and by changing the path a bit also to solve it:
root@dcmilphlum 173:~# grub-probe -d /dev/mapper/ vgos-rootsnapvo l 173:~# grub-probe -d /dev/vgos/ rootsnapvol 173:~#
grub-probe: error: unknown filesystem.
root@dcmilphlum
ext2
root@dcmilphlum
although both paths seem the same:
root@dcmilphlum 173:~# ls -la /dev/mapper/ vgos-rootsnapvo l vgos-rootsnapvo l -> ../dm-6 173:~# ls -la /dev/vgos/ rootsnapvol rootsnapvol -> ../dm-6 173:~#
lrwxrwxrwx 1 root root 7 Mar 18 06:30 /dev/mapper/
root@dcmilphlum
lrwxrwxrwx 1 root root 7 Mar 18 06:30 /dev/vgos/
root@dcmilphlum
PERSONAL CONCLUSION (please correct me if I'm wrong):
Also here I don't see any big danger, as grub shouldn't do anything with those snapshot volumes anyway...