Comment 5 for bug 274889

I'm an icon theme maintainer so I'll throw in my 2 cents here. Using drive-harddisk and view refresh is totally wrong. It prevents an icon theme from having a different graphical metaphor for e.g. refreshing a web page and restarting the computer, which are completely different actions, while drive-harddisk is a device icon, not an action. They just by chance happen to look the same in Gnome icon theme. The "sleep" name is too generic, and inconsistent with the terminology used in the dialog (the dialog text calls this action Suspend, not Sleep).

I propose either to revert to gnome-session-suspend, gnome-session-hibernate and gnome-session-restart like it was in Hardy, or to use Gnome Power Manager icons: gpm-suspend and gpm-hibernate, which are available at least in the Hicolor theme. Another option would be to copy icon names from KDE4 which are likely to make it into the fd.o spec.

So we have three solutions.
Solution 1: revert to previous names

#define GSM_ICON_LOGOUT "system-log-out"
#define GSM_ICON_SWITCH "gnome-session-switch"
#define GSM_ICON_SHUTDOWN "gnome-session-shutdown"
#define GSM_ICON_REBOOT "gnome-session-restart"
#define GSM_ICON_HIBERNATE "gnome-session-hibernate"
#define GSM_ICON_SLEEP "gnome-session-suspend"

Solution 2: use GPM icons

#define GSM_ICON_LOGOUT "system-log-out"
#define GSM_ICON_SWITCH "system-users"
#define GSM_ICON_SHUTDOWN "system-shutdown"
#define GSM_ICON_REBOOT "system-restart"
#define GSM_ICON_HIBERNATE "gpm-hibernate"
#define GSM_ICON_SLEEP "gpm-suspend"

Solution 3: use KDE icon names (probalbe fututre fd.o names) and fix the Gnome theme

#define GSM_ICON_LOGOUT "system-log-out"
#define GSM_ICON_SWITCH "system-users"
#define GSM_ICON_SHUTDOWN "system-shutdown"
#define GSM_ICON_REBOOT "system-restart"
#define GSM_ICON_HIBERNATE "system-suspend-hibernate"
#define GSM_ICON_SLEEP "system-suspend"

Afterwards, create symlinks in the Gnome and Human themes:
gpm-hibernate -> system-suspend-hibernate
gpm-suspend -> system-suspend
view-refresh -> system-restart

I myself would prefer the third option since icon themes for Gnome would get an extra bit of compatibility with KDE, but all of those are acceptable. Please show some compassion for icon theme authors and fix this.

Sorry for no patch but I don't know how to produce it - the above lines are not present in gsm-logout-dialog.c when I do apt-get source gnome-session.