Comment 15 for bug 399492

Revision history for this message
Scott Howard (showard314) wrote : Re: Feature request : Possible improvements for notifications

The first package is ready for testing.
This is my first time packaging, patching, using ppas, and bzr - so please bear with the extra commits and ppa versions while I figured out how to actually upload the files!

The ppa is here:
https://launchpad.net/~showard314/+archive/ppa

Could you please test it and check out why descriptions below (I'm running ~ppa3 now but don't have a good enough laptop with me to test it on)? Known bug: if you use this version with a latpop that has UPS, phone, wireless keyboard/mouse, or PDA attached to it, the peripheral battery information will be notified just as "battery" and not "phone battery" (this has to be fixed)

Also, if anyone knows quick ways to improve this or wants to work on the TO DOs below, please grab the bzr branch and work on the 09-concise-notification-osd patch!

Changes:

LOW BATTERY
[old]
title = "Laptop battery low"
message = "You have approximately 25 minutes of remaining battery life (10%)"
[new]
title = "Battery low"
message = "25 minutes remaining"
[TO DO]
-write a check to see if any other battery device peripherals(PDA, phone, wireless mouse/kb, UPS) exist on the system, if they do the title should remain "Laptop battery low" (does anyone know how to do that off the top of their head? I can figure it out but it may take a while...)
- we might need to make the message "25 minutes remaining (10%)" since the % is more accurate than the time

CRITICALLY LOW BATTERY
[old]
title = "Laptop battery critically low"
message = "You have approximately 25 minutes of remaining battery life (10%). This computer will <EVENT> in 15 minutes if the AC is not connected."
[new]
title = "Battery critically low"
message = "This computer will <EVENT> in 15 minutes."
[TO DO]
-write a check to see if any other device peripherals exist on the system, if they do the title should remain "Laptop battery critically low" to distinguish between the laptop battery and peripheral batteries
- we might need to make the message "This computer will <EVENT> in 15 minutes if the AC is not connected." to explicitly say what the alternative is (or is this intuitive?)

BATTERY FULL
[old]
title = "Power Information"
message = "Laptop battery fully charged (100%). Provides 2 hours 5 minutes of runtime."
[new]
title = "Power Information"
message = "Battery is full. Provides 2 hours 5 minutes runtime."
[TO DO]
- The "Power Information" title comes from one function, and the description string comes from another function. We would have to add a way to change the title depending on the event. Ideally the title = "Battery full" and the message = "Provides 2 hours 5 minutes of runtime"
- correct the bug where all batteries are labelled as "battery." this can be fixed by defining the string type_desc to be "Battery" if there are no peripherals and "Laptop battery" if there are peripherals.

BATTERY DISCHARGING
 [old]
title = "Power Information"
message = "Laptop battery 2 hours 5 minutes remaining (85%)."
[new]
title = "Power Information"
message = "2 hours 5 minutes remaining."
[TO DO]
- The "Power Information" title comes from one function, and the description string comes from another function. We would have to add a way to change the title depending on the event. Ideally the title = "2 hours 5 minutes remaining"
- correct the bug where all batteries are labelled as "battery." this can be fixed by defining the string type_desc to be "Battery" if there are no peripherals and "Laptop battery" if there are peripherals.
- again we may need to keep the percentage information.

BATTERY CHARGING
 [old]
title = "Power Information"
message = "Laptop battery 2 hours 5 minutes until charged (85%). Provides 2 hours 5 minutes battery runtime"
[new]
title = "Power Information"
message = "2 hours 5 minutes until charged. Provides 2 hours 5 minutes battery runtime."
[TO DO]
- The "Power Information" title comes from one function, and the description string comes from another function. We would have to add a way to change the title depending on the event. Ideally the title = "2 hours 5 minutes remaining"
- We may need to describe what has 2 hours 5 minutes until charged, in which case we can define type_desc to be "Battery" (or "") in systems with no peripherals and "Laptop battery" in others.
- again we may need to keep the percentage information.