Comment 36 for bug 274146

Revision history for this message
Vincent Untz (vuntz) wrote :

I quickly read the various comments. And here are my €0.02.

It's not clear to me whether you guys want to migrate panels from old users to the new config or not. If you do, you'll have to either patch the panel for the next 2-3 years (until next LTS, I guess?), or provide a small migration helper for the same amount of time. So, migration means code to maintain.

Then you have the issues of how to logout/shutdown/reboot. I didn't see the new applet, so those are purely comments from an upstream point of view:

 + note that you're already using a patch that I wrote for the logout dialogs. Those dialogs are not upstream, and some people upstream don't like it. FWIW, we ship them in openSUSE, so I expect the patch to be "maintained" by me at least.

 + you can add an additional patch to have one dialog. It's not hard, and I already talked a bit to Sebastien about this, I believe (you'll want to add a new ubuntu-specific dbus method, and copy & paste code to create the new dialog). However, this will most probably never go upstream.

 + if you don't migrate the panel config, you'll have to keep the logout/shutdown options in the menubar.

Now, my opinion: I would probably migrate the user setting, and only have logout/shutdown in the fusa applet. This means patching things out in the menubar (well, actually, you could dynamically detect if the fusa applet is on one panel and show/hide those items in the menubar).

My guess is that the fusa menu would directly contain logout/reboot/shutdown and you're doing a bit like OS X here. So in this case, you'd want to have new confirmation dialogs instead of the upstream dialogs which propose more than just "ok/cancel" (since the user has to choose if he wants to reboot or shutdown in this dialog). This means new code, either in gnome-session or in the applet.

[of course, all this is discussion that should happen upstream, because the work you've done to the fusa applet should have been done upstream]