Comment 11 for bug 211693

Revision history for this message
Matti Lindell (mlind) wrote :

Sebastien, could you review the backported patch. There seems to be some sort of logic error compared to patch that was applied upstream:
http://svn.gnome.org/viewvc/gnome-mount/trunk/src/gnome-mount.c?r1=167&r2=166&pathrev=167&limit_changes=100&view=patch

Upstream:
if (found) {
    goto try_drive;
} else {
    if (opt_eject) {

Ours:
if (found || opt_eject) {
    goto try_drive;
} else {
    if (opt_eject) {

I think the latter has a condition where 'else clause' is unreachable when ejecting a device.