Comment 8 for bug 261988

Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :

@Benjamin

Thanks so much for the review and suggestions!

I incorporated all your changes except for the short descriptions. I'm still not satisfied with them nor mine. Debian policy (3.4.1) explicitly states "Do not include the package name in the synopsis line. The display software knows how to display this already, and you do not need to state it." So I don't think that your descriptions work. Mine are also problematic, not least of all because lintian complains about them being the same. Need to think about this some more...

Did you look at debian/copyright? I'm not sure if I need to list Tango, ect in there or if pointing to the AUTHORS file is enough.

I went ahead and renamed the binaries to *-icon-theme as that seems to be the standard in the archive (i.e human-icon-theme, gnome-icon-theme). Maybe I should leave the meta-package simply gnome-colors though? I'm not sure whats best, sicking closer to the upstream name or following the general pattern of naming GNOME icon themes in the archive.

Also I went ahead and put this into a bzr branch. I had been meaning to do this already, but as someone else has taken an interest I figure I should do it now.

bzr branch lp:gnome-colors-pkg

or:

https://code.edge.launchpad.net/~gnome-colors-packagers/gnome-colors-pkg/debian

Also just a general update for all who are interested in the status of this.... As this missed Jaunty's feature freeze and Debian is now unfrozen, I am now aiming to submit the package directly to Debian. This way it will be synced into Karmic automatically. The Debian ITP has been linked above. The same goes for Shiki-Colors. See: Bug #328667

Also, my PPA package has diverged some what from the real packaging some what in order to make sure people with my PPA in their sources can upgrade cleanly.

@perfectska04 - Thanks so much for creating such a nice theme! Now I'm off to file a bug in your tracker about shiki-colors not having an explicit copyright notice. Having one will make it much easier to get into Debian. They can be pretty strict about such things. =)