Comment 10 for bug 186869

Revision history for this message
Loïc Minier (lool) wrote : Re: Can't change field types

I didn't find the first version number of Glom where this bug is fixed so I grabbed the latest 1.6 release (1.6.6 currently) and compared to the one in gutsy (1.6.0).

The diff exposes:
1) changes in the build rules:
-SUBDIRS = po glom docs macros examples xslt icons
+SUBDIRS = po glom macros examples xslt icons
+
+if HAVE_GNOME_DOC_UTILS
+SUBDIRS += docs
+endif

2) addition of a maemo port and subsequent bug fixes

3) different versions of autoconf and intltool were used to release the tarball

4) implementation of new build flags --enable-maemo, --enable-maemo-launcher and --enable-client-only

5) new logic for computation of the required pkg-config modules

6) misc code changes and bug fixes

This is the diffstat:
 configure.in | 93 +-
 glom-1.6.6/ChangeLog | 196 ++++
 glom-1.6.6/Makefile.am | 6
 glom-1.6.6/NEWS | 49 +
 glom-1.6.6/aclocal.m4 | 14
 glom-1.6.6/config.h.in | 6
 glom-1.6.6/glom/Makefile.am | 62 -
 glom-1.6.6/glom/application.cc | 429 ++++++++--
 glom-1.6.6/glom/application.h | 28
 glom-1.6.6/glom/base_db.cc | 185 +++-
 glom-1.6.6/glom/base_db.h | 8
 glom-1.6.6/glom/box_db.cc | 14
 glom-1.6.6/glom/box_db_table.cc | 6
 glom-1.6.6/glom/combobox_fields.cc | 6
 glom-1.6.6/glom/combobox_relationship.cc | 14
 glom-1.6.6/glom/dialog_connection.cc | 31
 glom-1.6.6/glom/dialog_connection.h | 4
 glom-1.6.6/glom/dialog_glom.cc | 2
 glom-1.6.6/glom/dialog_invalid_data.cc | 11
 glom-1.6.6/glom/filechooser_export.cc | 13
 glom-1.6.6/glom/frame_glom.cc | 265 ++++--
 glom-1.6.6/glom/frame_glom.h | 40
 glom-1.6.6/glom/glom.glade | 177 ----
 glom-1.6.6/glom/layout_item_dialogs/box_formatting.cc | 2
 glom-1.6.6/glom/libglom/Makefile.am | 16
 glom-1.6.6/glom/libglom/appstate.cc | 11
 glom-1.6.6/glom/libglom/connectionpool.cc | 167 +++
 glom-1.6.6/glom/libglom/connectionpool.h | 28
 glom-1.6.6/glom/libglom/data_structure/field.cc | 13
 glom-1.6.6/glom/libglom/data_structure/field.h | 3
 glom-1.6.6/glom/libglom/data_structure/fieldtypes.cc | 7
 glom-1.6.6/glom/libglom/data_structure/glomconversions.cc | 52 +
 glom-1.6.6/glom/libglom/data_structure/iso_codes.cc | 24
 glom-1.6.6/glom/libglom/document/document_glom.cc | 47 +
 glom-1.6.6/glom/libglom/document/document_glom.h | 35
 glom-1.6.6/glom/libglom/python_embed/py_glom_relatedrecord.cc | 51 -
 glom-1.6.6/glom/libglom/spawn_with_feedback.cc | 115 +-
 glom-1.6.6/glom/libglom/test_avahi_publisher.cc | 3
 glom-1.6.6/glom/libglom/utils.cc | 41
 glom-1.6.6/glom/libglom/utils.h | 6
 glom-1.6.6/glom/main.cc | 78 +
 glom-1.6.6/glom/mode_data/Makefile.am | 12
 glom-1.6.6/glom/mode_data/box_data.cc | 99 +-
 glom-1.6.6/glom/mode_data/box_data.h | 9
 glom-1.6.6/glom/mode_data/box_data_details.cc | 81 +
 glom-1.6.6/glom/mode_data/box_data_details.h | 5
 glom-1.6.6/glom/mode_data/box_data_list.cc | 68 +
 glom-1.6.6/glom/mode_data/box_data_list.h | 4
 glom-1.6.6/glom/mode_data/box_data_list_related.cc | 17
 glom-1.6.6/glom/mode_data/box_data_list_related.h | 10
 glom-1.6.6/glom/mode_data/dialog_layout_export.cc | 5
 glom-1.6.6/glom/mode_data/notebook_data.cc | 8
 glom-1.6.6/glom/mode_data/notebook_data.h | 3
 glom-1.6.6/glom/mode_design/fields/box_db_table_definition.cc | 35
 glom-1.6.6/glom/mode_design/fields/dialog_fieldcalculation.cc | 2
 glom-1.6.6/glom/mode_design/fields/dialog_fielddefinition.cc | 2
 glom-1.6.6/glom/mode_find/box_data_details_find.cc | 2
 glom-1.6.6/glom/mode_find/box_data_list_find.cc | 4
 glom-1.6.6/glom/navigation/box_tables.cc | 6
 glom-1.6.6/glom/notebook_glom.cc | 3
 glom-1.6.6/glom/python_embed/glom_python.cc | 9
 glom-1.6.6/glom/reports/Makefile.am | 12
 glom-1.6.6/glom/reports/report_builder.cc | 5
 glom-1.6.6/glom/utility_widgets/Makefile.am | 7
 glom-1.6.6/glom/utility_widgets/adddel/adddel.cc | 32
 glom-1.6.6/glom/utility_widgets/adddel/adddel_withbuttons.cc | 13
 glom-1.6.6/glom/utility_widgets/buttonglom.cc | 5
 glom-1.6.6/glom/utility_widgets/cellrendererlist.cc | 15
 glom-1.6.6/glom/utility_widgets/comboentryglom.cc | 26
 glom-1.6.6/glom/utility_widgets/comboentryglom.h | 7
 glom-1.6.6/glom/utility_widgets/comboglom.cc | 23
 glom-1.6.6/glom/utility_widgets/comboglom.h | 6
 glom-1.6.6/glom/utility_widgets/datawidget.cc | 275 ++++--
 glom-1.6.6/glom/utility_widgets/datawidget.h | 15
 glom-1.6.6/glom/utility_widgets/db_adddel/cellrenderer_buttonimage.cc | 58 +
 glom-1.6.6/glom/utility_widgets/db_adddel/cellrenderer_buttonimage.h | 5
 glom-1.6.6/glom/utility_widgets/db_adddel/cellrenderer_buttontext.cc | 54 +
 glom-1.6.6/glom/utility_widgets/db_adddel/cellrenderer_buttontext.h | 5
 glom-1.6.6/glom/utility_widgets/db_adddel/db_adddel.cc | 106 +-
 glom-1.6.6/glom/utility_widgets/db_adddel/db_adddel.h | 22
 glom-1.6.6/glom/utility_widgets/db_adddel/db_adddel_withbuttons.cc | 21
 glom-1.6.6/glom/utility_widgets/db_adddel/db_adddel_withbuttons.h | 2
 glom-1.6.6/glom/utility_widgets/db_adddel/glom_db_treemodel.cc | 250 +++++
 glom-1.6.6/glom/utility_widgets/db_adddel/glom_db_treemodel.h | 17
 glom-1.6.6/glom/utility_widgets/entryglom.cc | 26
 glom-1.6.6/glom/utility_widgets/entryglom.h | 6
 glom-1.6.6/glom/utility_widgets/filechooserdialog.cc | 25
 glom-1.6.6/glom/utility_widgets/filechooserdialog.h | 17
 glom-1.6.6/glom/utility_widgets/flowtable.cc | 291 ++++++
 glom-1.6.6/glom/utility_widgets/flowtable.h | 19
 glom-1.6.6/glom/utility_widgets/flowtablewithfields.cc | 44 -
 glom-1.6.6/glom/utility_widgets/imageglom.cc | 78 +
 glom-1.6.6/glom/utility_widgets/imageglom.h | 4
 glom-1.6.6/glom/utility_widgets/labelglom.cc | 9
 glom-1.6.6/glom/utility_widgets/layoutwidgetbase.cc | 8
 glom-1.6.6/glom/utility_widgets/layoutwidgetbase.h | 12
 glom-1.6.6/glom/utility_widgets/notebookglom.cc | 8
 glom-1.6.6/glom/utility_widgets/textviewglom.cc | 11
 glom-1.6.6/glom/utility_widgets/textviewglom.h | 4
 glom-1.6.6/glom/xsl_utils.cc | 27

So on my side, I'm not ready to review such a diff for a SRU; if you point me at the exact fixes which you consider critical enough to warrant review and update, I can try extracting them as isolated patches.