Comment 10 for bug 992618

Revision history for this message
undefined (undefined) wrote :

on lucid i receive the same traceback as avsd05 (or close enough; i'm too lazy to perfectly diff the two).

the missing patch: https://trac.gajim.org/changeset/12863.

the reason: exec_command() calls thread_interface() with only one argument (p.wait, which is the command to execute in the new thread; the second argument referenced in the traceback is python's implicit "self" argument to class methods). the version of ThreadInterface in lucid has all its __init__ arguments as required, where the revision the security patch was pulled from had only the first argument (after the implicit self) as required. revision 12863 includes the updated interface with the optional arguments.

applying the patch to src/gajim.py (the file referenced in changeset 12863 doesn't exist in this earlier revision due to later refactoring), while ignoring whitespace, messes up indentation, so i've created the attached patch.