Ubuntu
firefox package

  1. Bug #1160569
  2. Comment #166

Comment 166 for bug 1160569

Revision history for this message
In , Karlt (karlt) wrote :

Comment on attachment 8630422
Replace g_slice_set_config() with G_SLICE environment variable

The g_type_init() call has been dropped.
I don't know of a static constructor using GSlice in GLib 2.32.
Is there something that causes G_SLICE to be read during XPCOMGlueStartup with
GLib 2.32?
It would be good to keep this working for 2.32 because that is what the
precise test machines use.

>+#if defined(MOZ_WIDGET_GTK)
>+#if !GLIB_CHECK_VERSION(2, 32, 0)

The compile time glib version check is contrary to our goal of compiling the same code irrespective of the compile environment.

Can this just be "if MOZ_WIDGET_GTK == 2" ?

I'd also be happy to drop support for G_SLICE=always-malloc on versions prior
to 2.32 if that makes the g_thread_init situation simpler. However, I don't
know whether it is acceptable to call g_thread_init after g_type_init in
versions prior to 2.24.