Comment 3 for bug 414139

OK, so inside the firefox-3.0 directory I found another firefox directory, so what I had was:

  .mozilla/
       firefox - what was a blank/bad new set after the transition
       firefox.3.0-replaced - seemed reasonably new - maybe this was my old 3.0 world?
       firefox.3.0-replaced/firefox - That was my latest ff3.5 state prior to the upgrade - and moving that back to firefox is all good.

Some thoughts:
   1) Maybe I had firefox-3.5 running at the point the upgrade script ran ?
   2) I've got a feeling I saw two dialogs and clicked the same reply (keep ff3.5 settings) in both - but I can't remember the order/exact circumstances - I suspect I clicked a couple of links in pidgin that spawned /usr/bin/firefox for each one. Looking at the script I can see that the dialog box is spawned off and then the answer is processed - so there could be two scripts waiting for dialog entries at once, and from the mv's I can see that the firefox-3.5 could end up as a subdirectory of the firefox.3.0-replaced

So I think this script needs:

   a) A detection if firefox is currently running.
   b) Detection if the script has already started running and is waiting for the dialog
   c) Something that stops it trying to do the migration twice on the same set of data
   d) Error checking on the mv's etc
   e) A log of stdout/stderr

I suggest you could combine at least (c) and (e) - if you can get stdout/stderr to go into .mozilla/transition-to3.5.lockandlog and then check for that file existing early on and bail if it does maybe it would be safer.

Dave