Ubuntu
firefox-3.0 package

  1. Bug #195698
  2. Comment #294

Comment 294 for bug 195698

Revision history for this message
In , Kai Engert (kaie) wrote :

I think it could help understanding the code if you rename
mPasswordPromptAggregator => mTrackActivePasswordPrompt
mUserAndPasswordPromptAggregator => mTrackActiveUserAndPasswordPrompt
mTopAggregator => mActivePromptTracker

In function UnlockAggregator, please explain in a comment the purpose of your comparisons/tests.

+ while ((*mTopAggregator)->mLocked) {
+ if (!NS_ProcessNextEvent(thread))
+ return PR_FALSE;

I'm worried that you use a plain bool variable and this loop.
Is it guaranteed that "wake up after unlock" will always happen?