Mano, this is the actual behaviour with an updated patch:
1. left-click: toggle container open (CORRECT)
2. ctrl+left-click: open container contents in tabs (append) (CORRECT)
3. shift+left-click: open container contents in tabs in new window (CORRECT)
4. ctrl+shift+left-click: open container contents in tabs (replace) (CORRECT?)
5. middle-click: open container contents in tabs (append) (CORRECT)
6. ctrl+middle-click: open container contents in tabs (append) (CORRECT)
7. shift+middle-click: open container contents in tabs (replace) (CORRECT?)
8. ctrl+shift+middle-click: open container contents in tabs (replace) (CORRECT?)
"CORRECT?" items are mostly due to the fact we are simply passing the work to openContainerNodeInTabs that ends up calling whereToOpenLink(aEvent, false, true); If we want to change that behaviour we must patch _openTabSet too to force the opening in a new window.
Clicking both keys makes unclear the user will, in FX2 that does not open anything, should be the same here?
(In reply to comment #29)
> I think shift+middle-click for open-tabs-in-new-tabs makes sense in the toolbar and menu context as well.
this will most probably have the same behaviour as previous points, with shift+middle-click, whereToOpenLink will _replace_ contents with new tabs.
Mano, this is the actual behaviour with an updated patch:
1. left-click: toggle container open (CORRECT) left-click: open container contents in tabs (replace) (CORRECT?)
2. ctrl+left-click: open container contents in tabs (append) (CORRECT)
3. shift+left-click: open container contents in tabs in new window (CORRECT)
4. ctrl+shift+
5. middle-click: open container contents in tabs (append) (CORRECT) middle- click: open container contents in tabs (replace) (CORRECT?)
6. ctrl+middle-click: open container contents in tabs (append) (CORRECT)
7. shift+middle-click: open container contents in tabs (replace) (CORRECT?)
8. ctrl+shift+
"CORRECT?" items are mostly due to the fact we are simply passing the work to openContainerNo deInTabs that ends up calling whereToOpenLink (aEvent, false, true); If we want to change that behaviour we must patch _openTabSet too to force the opening in a new window.
Clicking both keys makes unclear the user will, in FX2 that does not open anything, should be the same here?
(In reply to comment #29) in-new- tabs makes sense in the toolbar and menu context as well.
> I think shift+middle-click for open-tabs-
this will most probably have the same behaviour as previous points, with shift+middle-click, whereToOpenLink will _replace_ contents with new tabs.