Comment 206 for bug 193141

Revision history for this message
In , Dietrich-mozilla (dietrich-mozilla) wrote :

(From update of attachment 303822)
>Index: browser/base/content/browser-places.js
>===================================================================
>RCS file: /cvsroot/mozilla/browser/base/content/browser-places.js,v
>retrieving revision 1.94
>diff -u -p -8 -r1.94 browser-places.js
>--- browser/base/content/browser-places.js 13 Feb 2008 15:43:17 -0000 1.94
>+++ browser/base/content/browser-places.js 17 Feb 2008 06:13:46 -0000
>@@ -769,20 +769,19 @@ var BookmarksMenuDropHandler = {
> * @param event
> * A dragover event
> * @param session
> * The active DragSession
> * @returns true if the user can drop onto the Bookmarks Menu item, false
> * otherwise.
> */
> canDrop: function BMDH_canDrop(event, session) {

should remove these params and fix the caller.

>Index: browser/components/places/content/controller.js
>===================================================================
>RCS file: /cvsroot/mozilla/browser/components/places/content/controller.js,v
>retrieving revision 1.202
>diff -u -p -8 -r1.202 controller.js
>--- browser/components/places/content/controller.js 14 Feb 2008 11:15:25 -0000 1.202
>+++ browser/components/places/content/controller.js 17 Feb 2008 06:13:51 -0000
>@@ -1406,17 +1406,22 @@ PlacesMenuDNDObserver.prototype = {
> this._view._selection = event.target.node;
> this._view._cachedInsertionPoint = undefined;
> if (event.ctrlKey)
> dragAction.action = Ci.nsIDragService.DRAGDROP_ACTION_COPY;
> xferData.data = this._view.controller.getTransferData(dragAction.action);
> },
>
> canDrop: function TBV_DO_canDrop(event, session) {

ditto

>-function PlacesTreeView(aShowRoot, aFlatList) {
>+function PlacesTreeView(aShowRoot, aFlatList, aOnOpenFlatContainer) {
> if (aShowRoot && aFlatList)
> throw("Flat-list mode is not supported when show-root is set");
>
> this._tree = null;
> this._result = null;
> this._collapseDuplicates = true;
> this._showSessions = false;
> this._selection = null;
> this._visibleElements = [];
> this._showRoot = aShowRoot;
> this._flatList = aFlatList;
>+ this._openContainerCallback = aOnOpenFlatContainer;

nit: _openFlatContainerCallback would've been clearer.