Comment 102 for bug 193141

Revision history for this message
In , Hskupin (hskupin) wrote :

(In reply to comment #11)
> I think that we need to make this:
>
> return droppingOnSelf || PlacesUtils.nodeIsReadOnly(node);

No. This code is fine. The erroneous code is here:
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/browser/components/places/content/tree.xml&rev=1.88&mark=772&&#772

PlacesControllerDragHelper.canDrop gets a view with id=51. As SQLite Manager tells me, it's the real root (parent of history, tags, all bookmarks). That's why the function always return false because this view is readonly. We have to pass the correct view to PlacesControllerDragHelper.canDrop.