Comment 9 for bug 346600

On Fri, 2009-04-10 at 10:02 +0000, Paul Sladen wrote:
> Ted, the teh FAIL here is there are two separate (different) tests for
> whether the action should be instant.
>
> If the course of action is determined by current log in status, then the
> menu-item needs to be set based on *the same test*.
>
> Alternatively, if the menu-item text is set based on a Gconf key, then
> the course-of-action needs to be based on *the same test* of checking
> the Gconf fail.
>
> At the moment, the left-hand doesn't know what the right-hand is (about
> to be) doing.

Paul,

I think you're missing a little part of the logic here. What we're
checking for to not show the dialog is two things:

  1) Has the user asked us not to in GConf
  2) Will PolicyKit popup a dialog asking for a password

So if the GConf key is set we should ALWAYS show a dialog, the question
becomes which one. The problem here is that we're misdetecting when
PolicyKit is going to show his, so we end up falling through the case of
not showing anything.

  --Ted