Comment 22 for bug 458904

Revision history for this message
Martin Pitt (pitti) wrote : Re: [Bug 458904] Re: When installing a node, euca_find_cluster fails to locate the cluster controller if instances are running

Steve Langasek [2009-11-02 11:06 -0000]:
> > > + [ -e "/etc/eucalyptus/avahi-daemon.conf" ] && opts="${opts} -f /etc/eucalyptus/avahi-daemon.conf"
>
> > Upstart scripts are "set -e" by default, so you are missing an "||
> > true" here.
>
> $ set -e
> $ [ -e "/etc/eucalyptus/avahi-daemon.conf" ] && opts="${opts} -f /etc/eucalyptus/avahi-daemon.conf"
> $ echo $?
> 1

(thanks for the confirmation)

> > > -exec avahi-daemon -D
> > > + [ -e "/etc/eucalyptus/avahi-daemon.conf" ] && conf="-f /etc/eucalyptus/avahi-daemon.conf" || :
> > > + exec avahi-daemon -D $conf
> > > +end script
>
> That doesn't appear to drop the -D at all? I guess maybe you mean:

No, it shouldn't. -D means "daemonize", and this should always be
done. What we want to do is to add -f /my/different/conffile.

> script
> conf=-D
> [ -e "/etc/eucalyptus/avahi-daemon.conf" ] && conf="-f /etc/eucalyptus/avahi-daemon.conf"
> exec avahi-daemon $conf
> end script

That would start avahi-daemon in non-daemon mode for euca; this might
work with upstart (haven't checked), but I advise against making such
changes in an SRU.

Martin

--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)