Comment 52 for bug 259631

Revision history for this message
Martin Pitt (pitti) wrote :

Dustin,

thanks a lot for working on this. I read the upstream commit, and it is a great improvement to the current situation. Using a Terminal is okay for now, since there are no cross-distro tools for DE agnostic password input. Using gksu if it exists would be a nice improvement, of course. I really like the idea of using a .desktop file, that should behave very well in file managers.

As for your debdiff:

  * Please don't use /usr/share/app-install/ for the .desktop file. That's used by gnome-app-install, and announcing this as an application doesn't make sense. For the same reason it shouldn't be under /usr/share/applications. I suggest to simply use /usr/share/ecryptfs-utils/.

 * Minor gotcha: You install ecryptfs-mount-private.txt into /usr/share/doc/ecryptfs-utils/. Debian Policy (12.3) requires that you are able to rm -r /usr/share/doc without any program behaviour. Also, it is not really helpful documentation in the sense of "I read this before installation". Thus I suggest to put it into /usr/share/ecryptfs-utils/, too.

 * debian/ecryptfs-utils.install: Oh, I wasn't aware that it's possible nowadays to specify absolute paths. If that works, I learned something new today. :-)

Many thanks for working on this!