Comment 1 for bug 488853

Revision history for this message
Loïc Minier (lool) wrote :

Looks ok, same comments as for evas (see bug #488923) in terms of maintenance, debian/*.shlibs file (many of these here!), in addition:
* error during the doc build:
/build/buildd/ecore-0.9.9.063/src/lib/ecore_fb/ecore_fb_private.h:19: Problem during constant expression evaluation: syntax error
* --disable-ecore-evas-dfb should be dropped
* less warnings, but new serious ones :-(
ecore_con_dns.c:135: warning: ignoring return value of 'write', declared with attribute warn_unused_result
ecore_x_netwm.c:1069: warning: array subscript is above array bounds (I certainly see xev.xclient.data.l declared as *5* longs, not 6), this is likely a case of stack corruption

Approved with the same provisions as evas