Tormod Volden ha scritto:
>> Ok, then /dev/sdc will not be removed.
>
> If I understand "Use the -Z flag only if root partition is mountd in a
> dmraid array." correctly, the "partitions" on the two (dmraid member)
> disks /dev/sda and /dev/sdb will be exposed, in my example above. This
> is why I think this patch is wrong.
In your example above, if your /dev/sdc is not part of an array, kernel will not
remove it. If it happens this is a bug.
If /dev/sda and /dev/sdb are part of an array, they will be removed, and this is
*not* a bug, why it should be..?
>
>> I don't consider that as a "special set-ups".
>
> I agree that Christian's set-up is a broken one that we don't need to
> support. Anyway it could be handy sometimes to overrule any dmraid meta
> data left over on a disk and tell the system to not use dmraid. This is
> why I like "nodmraid", which also would have solved Christian's problem.
Yes I agree, this could be an interesting feature, but imho is not relevant with
this issue.
> So maybe you could mark this bug "invalid" or "wontfix", but I would not
> say it is "Resolved" by the above patch.
Workaround (patch) that I added in the latest revision isn't elegant, but imho
it fixed that issue. If it doesn't, please reopen this bug and write a testcase.
Tormod Volden ha scritto:
>> Ok, then /dev/sdc will not be removed.
>
> If I understand "Use the -Z flag only if root partition is mountd in a
> dmraid array." correctly, the "partitions" on the two (dmraid member)
> disks /dev/sda and /dev/sdb will be exposed, in my example above. This
> is why I think this patch is wrong.
In your example above, if your /dev/sdc is not part of an array, kernel will not
remove it. If it happens this is a bug.
If /dev/sda and /dev/sdb are part of an array, they will be removed, and this is
*not* a bug, why it should be..?
>
>> I don't consider that as a "special set-ups".
>
> I agree that Christian's set-up is a broken one that we don't need to
> support. Anyway it could be handy sometimes to overrule any dmraid meta
> data left over on a disk and tell the system to not use dmraid. This is
> why I like "nodmraid", which also would have solved Christian's problem.
Yes I agree, this could be an interesting feature, but imho is not relevant with
this issue.
> So maybe you could mark this bug "invalid" or "wontfix", but I would not
> say it is "Resolved" by the above patch.
Workaround (patch) that I added in the latest revision isn't elegant, but imho
it fixed that issue. If it doesn't, please reopen this bug and write a testcase.
Cheers,
Giuseppe.