Comment 8 for bug 255837

Revision history for this message
Sebastian Harl (tokkee) wrote : Re: [Bug 255837] Re: collectd FTBFS in intrepid

Hi Devid,

On Sat, Oct 18, 2008 at 07:51:03PM -0000, Devid Antonio Filoni wrote:
> Ehm... I haven't uploaded the package, as you can see I haven't signed it...
> I'm sending the patch to upstream, don't worry ;)

Thanks for sending the glibc-2.8 fix to the collectd mailing list.

It would be nice though, if you could comment the hardening patch. Imho,
this does not fix anything but rather just hide some compiler warning. A
real fix would report an error and then act appropriately (I assume that
aborting the read makes the most sense but I did not look into the code
of the multimeter plugin yet).

Cheers,
Sebastian

--
Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/

Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety. -- Benjamin Franklin