Comment 12 for bug 338408

Hey Charlie,

2009/3/17 charliej <email address hidden>

> On Mon, 2009-03-16 at 15:50 +0100, Arnaud Quette wrote:
> >
> > 2009/3/14 charliej
> > Arnaud,
> >
> > Hey Charlie,
> >
> >
> >
> > Thank you for looking at this, IMHO this update will benefit
> > Ampache and
> > Rythmbox users. If there is any other way I can help out feel
> > free to
> > contact me.
> >
> > sure, become a Debian Maintainer (or a DD) and adopt coherence,
> > please ;-)
>
> Working on it! Actually I am thinking of going through the NM process.

eh, nice ^_^

> Having a problem of finding a Debian Member that lives close to me to
> get my key signed, but anyway that's a different can of worms.
>

well, it's an important point since it officially confirms your digital
identity for Debian!
you really have to put a high prio on this point and attend to an event or
manage somehow to get a DD signing your key.

I would be willing to take over python-coherence, as long as I could
> call on you from time to time with questions/sponsorship of package
> updates.

sure, I'm very opened to "training the new generation". it's part of a DD
role ;-)

> I am the current maintainer of Ampache and Ampache-themes.
> >
> >
> > more seriously, have you tested your patch?
>
> yes, but I now understand why the install and test worked but the actual
> patch did not work.
>

;-) you should never let false fixed go out. prefer to call to somebody or
RFH if needed.
using pdebuild is helpful to get the latest lintian.
also see my below cdbs remark.

> I've noticed several things there:
> > - "DEB_INSTALL_ARGS += -XMochiKit" should be "DEB_DH_INSTALL_ARGS +=
> > -XMochiKit"
>
> I am still unraveling the mysteries of CDBS and python packages. But
> after working on this package it makes more sense, but still have a lot
> to learn.
>

an hint with cdbs is to directly look at .mk files. these are fairly well
commented, and I found this more useful than the doc. the online examples
can be helpful too.
for debhelpers (ie dh_install), it's /usr/share/cdbs/1/rules/debhelper.mk

be sure that we always have to learn. life wouldn't be fun otherwise ;-)

> but will not be helpfull since the setup.py install the files directly
> > to python-coherence.
> > for the above to work, we should first go through debian/tmp using
> > DEB_DESTDIR
>

I've missed to mention the quick solution:
binary-predeb/python-coherence::
        /bin/rm -f
debian/python-coherence/usr/share/pyshared/coherence/web/static/MochiKit.js

note that both solutions are fine here since the fix is limited to 1 file.
so the move to tmp not really needed.
if in the future there is a need to split and spawn new binary pkg, then you
should go that way and use the .install files...

> - the added Build-dep doesn't add the coma to the previous entry,
> > - there was a typo in the added manpage (AVAILAB*L*E STORES)
>
> I have pushed these changes to the launchpad branch.
>

I've also noticed a strange .TH format (soft release instead of last edit
date), but have not read it thoroughly .

> - there is still a manpage missing for applet-coherence
>
> my bad missed that one hmmm. Going to get started on this in the am,
> along with rebuilding/testing the package with the above changes. I
> will post back when the manpage and tests are complete.

great, thanks.
note that as soon as your diff is validated, I'll upload the new release
with an added Uploaders field for you ;-)
that will be the first step of the take over.

> I'm still working on this, but in very low prio background mode... but
> > would be interested in some feedback from you since I don't use
> > coherence nor the associated software...
>
> That's fine, an associate program Ampache-3.5 is due out in about a
> month or so. Python-coherence makes use of Ampache's XML-API, and there
> will be some significant changes to the API with the 3.5 release, so
> this update of python-coherence is needed so coherence and ampache play
> nice. :) My intent, is to have both updated packages hit the archives
> at around the same time, if possible.

leave a bit of time for the build-dep (ie coherence) to get buildd job's
done, before sending ampache.
delaying by a day, and watching buildd logs to ensure everything is fine for
coherence is a good idea.
this will save build resources from failing to build to due the missing
coherence dep ;-)

cheers,
Arnaud