Comment 11 for bug 338408

Revision history for this message
Charlie_Smotherman (cjsmo) wrote : Re: Bug#518391: Patches for coherence

On Mon, 2009-03-16 at 15:50 +0100, Arnaud Quette wrote:
>
> 2009/3/14 charliej
> Arnaud,
>
> Hey Charlie,
>
>
>
> Thank you for looking at this, IMHO this update will benefit
> Ampache and
> Rythmbox users. If there is any other way I can help out feel
> free to
> contact me.
>
> sure, become a Debian Maintainer (or a DD) and adopt coherence,
> please ;-)

Working on it! Actually I am thinking of going through the NM process.
Having a problem of finding a Debian Member that lives close to me to
get my key signed, but anyway that's a different can of worms.

I would be willing to take over python-coherence, as long as I could
call on you from time to time with questions/sponsorship of package
updates. I am the current maintainer of Ampache and Ampache-themes.
>
>
> more seriously, have you tested your patch?

yes, but I now understand why the install and test worked but the actual
patch did not work.

> I've noticed several things there:
> - "DEB_INSTALL_ARGS += -XMochiKit" should be "DEB_DH_INSTALL_ARGS +=
> -XMochiKit"

I am still unraveling the mysteries of CDBS and python packages. But
after working on this package it makes more sense, but still have a lot
to learn.

> but will not be helpfull since the setup.py install the files directly
> to python-coherence.
> for the above to work, we should first go through debian/tmp using
> DEB_DESTDIR
> - the added Build-dep doesn't add the coma to the previous entry,
> - there was a typo in the added manpage (AVAILAB*L*E STORES)

I have pushed these changes to the launchpad branch.

> - there is still a manpage missing for applet-coherence

my bad missed that one hmmm. Going to get started on this in the am,
along with rebuilding/testing the package with the above changes. I
will post back when the manpage and tests are complete.
>
> I'm still working on this, but in very low prio background mode... but
> would be interested in some feedback from you since I don't use
> coherence nor the associated software...

That's fine, an associate program Ampache-3.5 is due out in about a
month or so. Python-coherence makes use of Ampache's XML-API, and there
will be some significant changes to the API with the 3.5 release, so
this update of python-coherence is needed so coherence and ampache play
nice. :) My intent, is to have both updated packages hit the archives
at around the same time, if possible.
>

Cheers
Charlie