Comment 7 for bug 495023
Revision history for this message
| Andrew Bennetts (spiv) wrote Re: Interrupting commit to smart server sometimes removes files | #7 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
f33e652
(Get the code!)
> in your patch, I think we need to check the return code of
> PyErr_CheckSignals and return - or will pyrex automatically take care
> of that if an exception is raised?
Pyrex will take care of that, that's what the 'except -1' in the import
declaration for PyErr_CheckSignals does.
> It looks like we actually need similar handling in every case where
> this code is turning errno into an OSError or similar.
Yeah. Or at least for every case where errno might be EINTR or
otherwise caused by the arrival of a signal... I'm not sure if there are
any?. A common function sounds like a good idea.