Comment 9 for bug 94494

Revision history for this message
Fabien Tassin (fta) wrote :

I've looked at the xul patches shipped in songbird sources, some are IMHO problematic in a shared xulrunner SDK like we have in Ubuntu.

- bugCrashReporterStrings.patch: it hardcodes 'Songbird' as Vendor for CrashReporter (yet we don't build with crashreporter by default in ubuntu so it's minor for us)

- bugFaviconExpiration.patch: this changes an API. It's not a frozen one but I don't know the impact it could have on the other apps we have using xulrunner 1.9. Why isn't this patch posted in (Mozilla) BugZilla ?

- bug-songbird-4080-forms-styling.patch: it imports a songbird CSS unconditionally in a file heavily used by all Mozilla apps (especially ff, sm but also tb), meaning it will trigger an error when songbird is not installed.

- bug-toolkit-mousethrough.patch: not sure. It seems it changes a default behavior. Is it wanted in the shared SDK?

- bugTreeSelection.patch: Why isn't this patch posted in BugZilla ?