Comment 15 for bug 118589

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your work on that. I looked at the package on REVU, some comments

* avant-window-navigator.1

not sure that the fact that the application is written in C is of any interest in a manpage

* awn-applet-activation.1

you use "awn-applet-activation", "Awn-applet-activation", "wwn-applet-activation", consistency would be nice there

* awn-manager.1

The synopsys formatting looks incorrect

* control:

libawn-dev should Depends on libawn0 (= ${binary:Version})
the library description could be improved
awn-manager should be arch all

* copyright

you mention that the code is underl GPL2 only where the source files state it's GPL2 or any new version
you list awn-applet-*.* using the LGPL, src/awn-applet-* are under the GPL though and eggtraymanager which is not distributed in the source
you wrote " License (everything not mentioned below)" and list copyright holders which is slightly weird

* rules

you should "+=" for assignement to add arguments to the one which might be already used

* The manpages synopsis are not meant to be a copy of the description but a summary of the command name and options it can use

The copyright issues have to be fixed before the package can be uploaded