Comment 99 for bug 214366

Revision history for this message
In , Acelists (acelists) wrote :

(In reply to :Irving Reid from comment #88)
> I'm OK with this approach. I'd like to see test cases for both a single
> folder and a nested folder - for example:
>
I'll try.

> We don't need to test all those combinations for every message store type,
> but we should at least test the copyFolder(...aNewName) parameter works once
> on each store type.
Store type as in mbox and maildir? Do we actually have tests differentiating the stores?
Can't bug 765926 cover maildir by itself?

> ::: mailnews/local/src/nsLocalMailFolder.cpp
> @@ +1732,5 @@
> > + while (1) {
> > + rv = CheckIfFolderExists(newFolderNameUnderTrash, this, NULL);
> > + if (rv == NS_MSG_FOLDER_EXISTS) {
> > + newFolderNameUnderTrash.Assign(folderName);
> > + newFolderNameUnderTrash.AppendLiteral("-"); // do we want this localizable? "<folder>-<SeqNo>"
>
> I don't think this needs to be localizable.
I think it should be localizable if it is not complicated.

And I agree with comment 87.