Comment 73 for bug 214366

Revision history for this message
In , Acelists (acelists) wrote :

Created attachment 609152
proof of concept patch

I managed to strip the patch down and update it for the current architecture.
I need feedback from David Bienvenu if this is a good direction and reaction to the points below.

What it does:
- it does work to fix the problem as reported.
- if the folder 'Folder' is already existing in Trash, this will try to move it as 'Folder2', 'Folder3' (to fix comment 8).

What it is missing for now:
- if CopyFolderLocal is used not only for moving to trash then this renaming functionality must be done only if isChildOfTrash is true.
- it doesn't have the alert dialog informing the user the folder was renamed.

Problems:
- for some reason when a folder is deleted and then a new folder with the same name is created in its place, then it can't be deleted, without any error. It that is some other known bug or a bug in this code? After TB restart that same folder can be deleted fine.