Mozilla Thunderbird

  1. Bug #214366
  2. Comment #116

Comment 116 for bug 214366

Revision history for this message
In , Neil-httl (neil-httl) wrote :

Comment on attachment 8371072
WIP patch 3

>+ nsAutoString newFolderName(EmptyString());
[Strings default to empty...]

>+ while (containsChild) {
>+ rv = ContainsChildNamed(newFolderName, &containsChild);
>+ NS_ENSURE_SUCCESS(rv, rv);
>+ if (!containsChild)
>+ break;
[Weird use of loop condition.]

>+ newFolderName.AppendLiteral("(");
[Could use Append('(');]

>+confirmDuplicateFolderRename=A folder with that name already exists. Would you like to copy the folder under a different name?
You should include the suggested new folder name in the message, otherwise the user will expect to choose the new name.