Rosetta experts not allowed to "Change translators"

Bug #127171 reported by Jeroen T. Vermeulen
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Adi Roiban

Bug Description

I'm a Translations Expert (or Rosetta Admin, or the other way around) but I cannot access the "Change translators" page.

For example, if I go here: https://translations.launchpad.net/pmount/+translations I am offered the Change translators option, but if I click it, I get:

  Not allowed here
  Sorry, you don't have permission to access this page.
  You are logged in as [...]

Related branches

Changed in rosetta:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Данило Шеган (danilo) wrote :

Closely related to #89043.

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Okay, let's linkify that bug reference: this bug is closely related to bug 89043 (don't show "Change translators" link to people who aren't allowed to use it).

description: updated
Changed in rosetta:
importance: Medium → High
Adi Roiban (adiroiban)
Changed in rosetta:
assignee: nobody → Adi Roiban (adiroiban)
status: Triaged → In Progress
Revision history for this message
Adi Roiban (adiroiban) wrote :

The same template is used for both product and distribution.

This is why I also gave Rosetta admins access to distribution settings.

Is there a good reason for Rosetta admins or distribution translation group owners should to not have access to the page for changing translation group and translation policy?

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Rosetta admins should definitely have access to those. Distribution translation group owners should also have access for the case of a distribution.

Whether the owner of a project's translation group should have access to these settings for the project is a new question AFAIK. I would say yes, they should.

Granting group owners access does allow them to "lock themselves out," by clearing the group's selection for the project accidentally. The owner would not be able to change that back—but I don't think that'd be a major problem. It's a matter of re-contacting the project owner.

Conversely, the translation group owner may want to un-select the group deliberately; the project may not meet the group's requirements on source-code licensing, for instance. It takes two to tango. If there is no consent between the group and the project, there's no point in having the relationship in the first place.

Curtis Hovey (sinzui)
Changed in rosetta:
milestone: none → 10.02
Revision history for this message
Данило Шеган (danilo) wrote :

I don't think either of distribution or project translation group owners should have access to this. The reason one might want to have it is to allow them to unassign themselves from the responsibility, but if we let them access the page unrestricted, they'd be able to put it on a group which project/distro owners don't want it on.

So, Adi, if you are working on a fix for this, please limit it to 'rosetta-admins' or only allow group owners to unassign the group from a project/distribution.

Revision history for this message
Adi Roiban (adiroiban) wrote :

OK. I will try to implement with „rosetta-admin” and if everything is fine, group owner unassigns as a bonus.

I assume „rosetta-admin” should have launchpad.Edit permission only IHasTranslationGroup part of a Product or Distribution, and not for the whole Product/Distribution.

I'm still trying to figure out how to move the IHasTranslationGroup interface from being inherited to being delegated and plug into the ZCML and Zope.

Revision history for this message
Adi Roiban (adiroiban) wrote :

I think we need to decide the URL for this page.

Right now it is +changetranslators, but with bug #422056, we also have the translation focus on the same page.

Maybe we can rename it „+translation-policy”. This is used on IProduct, IProject and IDistribution

We already have the „+translations-setting” in ISeries for setting translations import and export.

What do you think?

Adi Roiban (adiroiban)
Changed in rosetta:
status: In Progress → Fix Committed
tags: added: qa-needstesting
Adi Roiban (adiroiban)
tags: added: qa-ok
removed: qa-needstesting
Changed in rosetta:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.