QEMU

  1. Bug #1874073
  2. Comment #12

Comment 12 for bug 1874073

Revision history for this message
Eric Blake (eblake) wrote : Re: [PATCH] hw/openrisc/openrisc_sim: Add assertion to silent GCC warning

On 6/9/20 3:42 PM, Stafford Horne wrote:

>>> While humans can tell smp_cpus will always be in the [1, 2] range,
>>> (openrisc_sim_machine_init sets mc->max_cpus = 2), the compiler
>>> can't.
>>>
>>> Add an assertion to give the compiler a hint there's no use of
>>> uninitialized data.
>>>

> Acked-by: Stafford Horne <email address hidden>
>
> I see there are now two patches for this, I kind of like this assert fix.
>
> Shall I queue it for OpenRISC pulling? Or can someone else pick this up?

Looks like Laurent already volunteered to queue it through the trivial
patches tree.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org