Comment 2 for bug 205782
Revision history for this message
|
|
#2 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Created attachment 294074
WIP, full patch of all my changes so far including preliminary favicon support
This patch includes the code for bugs 400179 and 408362. I haven't posted the latter yet since I want to test on Windows first. Currently includes support for Windows and Mac, tested only on Mac.
Currently I download the favicon to the profile directory, which is kind of a hack, and then check whether it is there when the user clicks OK to create the app/shortcut. So if they click before the icon is downloaded they will get the default app icon. I'll figure out a way to hold the icon in memory so it doesn't have to be written to disk. The UI should take care of showing the user that the icon is loading and displaying it once it is loaded so they can decide if they want it or some other icon.