Comment 6 for bug 687752

Revision history for this message
Julian Edwards (julian-edwards) wrote : Re: [Bug 687752] Re: It's impossible to check a librarian file's hash once it's expired

On Friday 10 December 2010 06:50:03 you wrote:
> Moving the hash from LFC to LFA is duplicating the hash - there can be
> multiple LFAs linked to an LFC. It will complicate garbage collection
> logic, and the data model is broken (well... denormalized) in that you
> could have multiple LFAs with differing hashes pointing to an LFC.

I think the multiple LFA per LFC is model is a little weird, personally. If
it's the same file, it should be the same LFA. Then you'd not have this
denormalization.

> I'm not sure how your intended work flow plays with other users of the
> Librarian. If a file is uploaded into the Librarian from some other part
> of Launchpad, will the publisher refuse to publish it?

That will never be a problem because Soyuz looks for files that only it
uploaded, linked through an archive and publication of some sort.

> The alternative
> of having a table of hashes that Soyuz will block uploads for seems
> simpler for everyone.

You're talking about not denormalizing the librarian model, yet you're
advocating Soyuz effectively do it anyway? I don't understand that.

However, I do concede that adding a hash to one of the Soyuz tables will
indeed be very easy. But is it the right thing to do?