Comment 6 for bug 643699

Revision history for this message
Martin Pool (mbp) wrote : Re: [Bug 643699] Re: Non-graphical browsers hide autorize-token messages

Hi Luca,

Can you please propose a branch to merge into launchpadlib?

A few points about the patch:

 * won't stdin.readline() block until the user presses enter?
 * pausing 5s even in the common case of having a graphical browser
available seems unfortunate; the process is already slower than one
might like (as Gary said)

<http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=584556> says

> I ran lp-shell vaguely expecting to get a stdio prompt. It fired up my $BROWSER, w3m, with a single [continue] button on the default page.

istm that's a bug in the sso provider and ought to be reported
independent of this. If the web server gave a reasonable message,
client changes might not be necessary. For instance if your web
browser started and said

  The program 'lp-shell' on 'sarcastic' is requesting access to your
Launchpad account [blah blah]
  [allow] [deny]

Martin

On 3 October 2011 08:04, Bug Watch Updater <email address hidden> wrote:
> ** Changed in: debian
>       Status: Confirmed => Fix Released
>
> --
> You received this bug notification because you are subscribed to
> launchpadlib .
> https://bugs.launchpad.net/bugs/643699
>
> Title:
>  Non-graphical browsers hide autorize-token messages
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/launchpadlib/+bug/643699/+subscriptions
>
>