Comment 11 for bug 643224

Revision history for this message
Martin Pool (mbp) wrote : Re: [Bug 643224] Re: dkim whitelist should be in configuration

On 23 February 2011 00:25, Gavin Panella <email address hidden> wrote:
> What are the advantages of using flags as opposed to, say, a db table,
> administered via the web service?

+ it doesn't need a new db table, and doesn't need a rollout
+ seems like a smaller change
+ don't need to write a special gui or client tool to set them
+ we get an audit trail and a web view of it for free from sinzui's work
+ by making all types of dynamic configuration be in the same place we
perhaps make lp easier to change and administer

disadvantages:

- storing them as text in a more generic table is a bit denormalized
- arguably this is a different kind of configuration to "turn this
feature on or off in this scope" because it will probably never be
appropriate to turn it on across the board, so perhaps it ought to
live somewhere different
- the editor gui has no domain knowledge or validation — but it could
grow it in future based on the scope/rule metadata