Comment 4 for bug 596796
Revision history for this message
| Martin Pool (mbp) wrote Re: [Bug 596796] Re: Can't add an pre-req branch to an existing MP | #4 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
On 24 June 2010 00:28, Aaron Bentley <email address hidden> wrote:
> The changes introduced in a prerequisite branch are not in the scope of
> a code review. This is why they are not shown in the diff.
>
> If you could change/add/remove the prerequisite branch, you would be
> changing the scope of the code review. By deleting a prerequisite
> branch, you could retroactively cause an approval of changes that the
> reviewer had never seen. By adding a merge proposal, you could remove
> changes that the reviewer might consider vital.
It seems to me Launchpad does not have a very clear position on
whether mps are meant to be immutable after creation, or not. You can
change some data fields such as the commit message, and you can change
the code by pushing more. However you can't change the prereq branch.
I don't understand why the former ought to be permitted and not the
latter.
I think making drastic changes once the code is under review would be
rude or annoying but that might be better handled socially.
If the mp needs to be locked because for example it's approved for
automatic landing, perhaps all changes should be locked out. But for
something still undergoing discussion that seems unnecessary.
--
Martin